Added ability to specify sort order for person/contact search results #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortha
force-pushed
the
sort-person-search-results
branch
from
d75a118 to
3ed845a
Compare
hortha
force-pushed
the
sort-person-search-results
branch
from
3ed845a to
1833e72
Compare
gunndabad
reviewed
Sep 15, 2023
TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/Index.cshtml
Outdated
Show resolved
Hide resolved
hortha
force-pushed
the
sort-person-search-results
branch
from
cb9c470 to
4514bc8
Compare
hortha
force-pushed
the
sort-person-search-results
branch
from
4514bc8 to
edf8394
Compare
gunndabad
reviewed
Sep 18, 2023
TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/Index.cshtml.cs
Outdated
Show resolved
Hide resolved
gunndabad
approved these changes
Sep 18, 2023
hortha
force-pushed
the
sort-person-search-results
branch
from
d718f8f to
e8bd3d1
Compare
…ch results returned
…Persons/Index.cshtml.cs Co-authored-by: James Gunn <[email protected]>
hortha
force-pushed
the
sort-person-search-results
branch
from
e8bd3d1 to
12d1fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users need to be able to sort person search results so that they can more quickly identify the person they’re looking for.
Changes proposed in this pull request
Add a ‘Sort by’ drop down following the designs in Figma.
Add the following options:
Last name (A-Z)
Last name (Z-A)
First name (A-Z)
First name (Z-A)
Date of birth (ascending)
Date of birth (descending)
Update the queries to honour the requested sort by option. The chosen option should be passed around as a query parameter.
‘Last name (A-Z)' should be the default option.
Guidance to review
CRM Query changes + UI + tests
Checklist